feat: cns logger v2 [1/2] #3437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 6 out of 12 changed files in this pull request and generated 4 comments.
Files not reviewed (6)
- go.mod: Language not supported
- cns/logger/cnslogger_windows.go: Evaluated as low risk
- cni/log/logger_windows.go: Evaluated as low risk
- zapetw/core_windows.go: Evaluated as low risk
- cns/logger/v2/logger_linux.go: Evaluated as low risk
- cns/logger/v2/logger_windows.go: Evaluated as low risk
Comments suppressed due to low confidence (1)
cns/logger/v2/cores/etw_windows.go:17
- The comment should specify that the second return value is a function to close the provider for clarity.
// The first return is the core, the second is a function to close the sink.
rbtr
force-pushed
the
feat/cns-zapai-migration
branch
from
5e2ebf4 to
dec6d16
Compare
rbtr
force-pushed
the
feat/cns-zapai-migration
branch
2 times, most recently
from
7b3c7cc to
0294ccd
Compare
timraymond
reviewed
Feb 21, 2025
Signed-off-by: Evan Baker <[email protected]>
Signed-off-by: Evan Baker <[email protected]>
rbtr
force-pushed
the
feat/cns-zapai-migration
branch
from
0294ccd to
d3bbfc8
Compare
rbtr
commented
Feb 21, 2025
rbtr
commented
Feb 21, 2025
Signed-off-by: Evan Baker <[email protected]>
Signed-off-by: Evan Baker <[email protected]>
Signed-off-by: Evan Baker <[email protected]>
Collaborator
Author
|
/azp run Azure Container Networking PR |
Contributor
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jpayne3506
approved these changes
Feb 26, 2025
jackieluc
reviewed
Feb 27, 2025
paulyufan2
approved these changes
Feb 27, 2025
QxBytes
approved these changes
Feb 27, 2025
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* feat: add new v2 zap logger package to CNS Signed-off-by: Evan Baker <[email protected]> * update loggerv2 configs, add custom Unmarshalling Signed-off-by: Evan Baker <[email protected]> * add custom Duration type, tests, cores enabled by config Signed-off-by: Evan Baker <[email protected]> * add config normalization for logger v2 Signed-off-by: Evan Baker <[email protected]> * lints Signed-off-by: Evan Baker <[email protected]> --------- Signed-off-by: Evan Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds v2 logger package for CNS. [1/2]
The v2 logger is built with zap and offers structured logging, derived contexts, multiple output targets and formats including stdout, files, ETW, and AppInsights.
The logger constructor is opinionated and will initialize targets and formats fully based on what is supported per-platform. The logger is intended to be used directly.
This pt. 1 change is strictly the addition of the v2 logger package machinery.